netdev - Re: [net 1/8] igb: Update queue reinit function to call dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 29 Nov 2013 15:47:57 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	jeffrey.t.kirsher@...el.com
Cc:	carolyn.wyborny@...el.com, netdev@...r.kernel.org,
	gospo@...hat.com, sassmann@...hat.com
Subject: Re: [net 1/8] igb: Update queue reinit function to call dev_close
 when init of queues fails

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Wed, 27 Nov 2013 23:35:55 -0800

> From: Carolyn Wyborny <carolyn.wyborny@...el.com>
> 
> This patch adds a call to dev_close if the queue reinit fails in order
> to make clearer to the user that the device is down.
> 
> Signed-off-by: Carolyn Wyborny <carolyn.wyborny@...el.com>
> Tested-by: Aaron Brown <aaron.f.brown@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>

This is a very bad approach to this problem.

Users absolutely do not expect their entire interface to go down
simply because an ethtool request cannot be satisfied.  This is
extremely poor quality of implementation.

And in this specific case it absolutely is not necessary.

The only thing that can fail is the queue allocation, so make a
function which can preserve the previous configuration if the queue
allocation fails.  How about "igb_reinit_interrupt_scheme".

Don't free the q vectors until the very last moment, when you know
that the allocation of the new q vectors has succeeded.

I'm not applying this patch, it needs to be reimplemented more
sanely, using the above suggestions or similar.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html