netdev - Re: [PATCH v2 13/17] net: mlx4 calls skb_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 01 Dec 2013 14:26:31 +0200
From:	Amir Vadai <amirv.mellanox@...il.com>
To:	Tom Herbert <therbert@...gle.com>, netdev@...r.kernel.org,
	davem@...emloft.net
CC:	Hadar Hen Zion <hadarh@...lanox.com>
Subject: Re: [PATCH v2 13/17] net: mlx4 calls skb_set_rxhash

On 26/11/2013 19:31, Tom Herbert wrote:
> Drivers should call skb_set_rxhash to set the rxhash and its type
> in an skbuff.
> 
> Signed-off-by: Tom Herbert <therbert@...gle.com>
> ---
>  drivers/net/ethernet/mellanox/mlx4/en_rx.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx4/en_rx.c b/drivers/net/ethernet/mellanox/mlx4/en_rx.c
> index 07a1d0f..3e48c44 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/en_rx.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/en_rx.c
> @@ -747,7 +747,7 @@ int mlx4_en_process_rx_cq(struct net_device *dev, struct mlx4_en_cq *cq, int bud
>  					}
>  
>  					if (dev->features & NETIF_F_RXHASH)
> -						gro_skb->rxhash = be32_to_cpu(cqe->immed_rss_invalid);
> +						skb_set_rxhash(gro_skb, be32_to_cpu(cqe->immed_rss_invalid), RXHASH_TYPE_L3);
>  
>  					skb_record_rx_queue(gro_skb, cq->ring);
>  
> @@ -789,7 +789,7 @@ int mlx4_en_process_rx_cq(struct net_device *dev, struct mlx4_en_cq *cq, int bud
>  		skb_record_rx_queue(skb, cq->ring);
>  
>  		if (dev->features & NETIF_F_RXHASH)
> -			skb->rxhash = be32_to_cpu(cqe->immed_rss_invalid);
> +			skb_set_rxhash(skb, be32_to_cpu(cqe->immed_rss_invalid), RXHASH_TYPE_L3);
>  
>  		if ((be32_to_cpu(cqe->vlan_my_qpn) &
>  		    MLX4_CQE_VLAN_PRESENT_MASK) &&
> 

I need to do some work in this area of code, but anyway it is not in the
scope of this patchset.

Acked-By: Amir Vadai <amirv@...lanox.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html