netdev - Re: [PATCH 3/7] net: of_mdio: do not overwrite PHY interrupt configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 06 Dec 2013 03:45:04 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Florian Fainelli <florian@...nwrt.org>, netdev@...r.kernel.org
CC:	davem@...emloft.net, grant.likely@...aro.org,
	devicetree@...r.kernel.org, abrodkin@...opsys.com,
	rob.herring@...xeda.com, mark.rutland@....com,
	sebastian.hesselbarth@...il.com,
	Florian Fainelli <f.fainelli@...il.com>
Subject: Re: [PATCH 3/7] net: of_mdio: do not overwrite PHY interrupt configuration

Hello.

On 12/06/2013 01:52 AM, Florian Fainelli wrote:

> From: Florian Fainelli <f.fainelli@...il.com>

> If irq_of_parse_and_map fails to find an interrupt line for a given PHY,
> we will force the PHY interrupt to be PHY_POLL, completely overriding
> the previous value that the MDIO bus may have set for us (e.g:
> PHY_IGNORE_INTERRUPT). In case of failure, just restore the previous
> value.

> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
> ---
>   drivers/of/of_mdio.c | 5 +++--
>   1 file changed, 3 insertions(+), 2 deletions(-)

> diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c
> index f93ebca..4923ab2 100644
> --- a/drivers/of/of_mdio.c
> +++ b/drivers/of/of_mdio.c
[...]
> @@ -37,10 +37,11 @@ static int of_mdiobus_register_phy(struct mii_bus *mdio, struct device_node *chi
>   		return 1;
>
>   	if (mdio->irq) {
> +		prev_irq= mdio->irq[addr];

    You forgot space before =.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html