netdev - Re: [PATCH] ipv6: don't count addrconf generated routes against gc limit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 06 Dec 2013 16:21:24 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	hannes@...essinduktion.org
Cc:	netdev@...r.kernel.org, brett.ciphery@...driver.com
Subject: Re: [PATCH] ipv6: don't count addrconf generated routes against gc
 limit

From: Hannes Frederic Sowa <hannes@...essinduktion.org>
Date: Fri, 6 Dec 2013 18:25:56 +0100

> @@ -2166,7 +2166,8 @@ struct rt6_info *addrconf_dst_alloc(struct inet6_dev *idev,
>  				    bool anycast)
>  {
>  	struct net *net = dev_net(idev->dev);
> -	struct rt6_info *rt = ip6_dst_alloc(net, net->loopback_dev, 0, NULL);
> +	struct rt6_info *rt = ip6_dst_alloc(net, net->loopback_dev,
> +					    DST_NOCOUNT, NULL);
>  
>  	if (!rt) {
>  		net_warn_ratelimited("Maximum number of routes reached, consider increasing route/max_size\n");

So basically, we only want to count routes that will have RTF_CACHE
set on them.

This warning in the net_warn_ratelimited() is no longer relevant, only
hard memory allocation failures can result in this !rt condition.  So
please respin this patch with that warning removed.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html