netdev - Re: [PATCH net 2/8] sfc: PTP: Moderate log message on event queue overflow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 11 Dec 2013 02:20:39 +0000
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Joe Perches <joe@...ches.com>
CC:	David Miller <davem@...emloft.net>, <netdev@...r.kernel.org>,
	<linux-net-drivers@...arflare.com>
Subject: Re: [PATCH net 2/8] sfc: PTP: Moderate log message on event queue
 overflow

On Tue, 2013-12-10 at 18:15 -0800, Joe Perches wrote:
> On Wed, 2013-12-11 at 01:53 +0000, Ben Hutchings wrote:
> > From: Laurence Evans <levans@...arflare.com>
> []
> > diff --git a/drivers/net/ethernet/sfc/ptp.c b/drivers/net/ethernet/sfc/ptp.c
> []
> > @@ -270,6 +271,7 @@ struct efx_ptp_data {
> >  	struct list_head evt_list;
> >  	struct list_head evt_free_list;
> >  	spinlock_t evt_lock;
> > +	bool evt_overflow;
> 
> It might be nice to move the bools in this struct together
> to reduce the number of struct holes.

There's only one of these per device.  I don't think saving a few bytes
outweighs the benefit of having related fields grouped together.

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html