netdev - Re: [net-next 11/15] i40e: debugfs command to change RSS queue count

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 12 Dec 2013 20:41:15 +0000
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
CC:	<davem@...emloft.net>,
	Anjali Singhai Jain <anjali.singhai@...el.com>,
	<netdev@...r.kernel.org>, <gospo@...hat.com>,
	<sassmann@...hat.com>,
	"Jesse Brandeburg" <jesse.brandeburg@...el.com>
Subject: Re: [net-next 11/15] i40e: debugfs command to change RSS queue count

On Thu, 2013-12-12 at 04:40 -0800, Jeff Kirsher wrote:
> From: Anjali Singhai Jain <anjali.singhai@...el.com>
> 
> This is the 3rd of 3 patches that implements changing the number
> of queues on the fly.
> 
> This patch adds the debugfs hook for calling the change queues
> flow with a request to change the number of RSS queues.
> 
> This is intended to also be called eventually from ethtool.

The ethtool set_channels operation is implemented in 12/15, so why
include this awful interface as well?

Ben.

> Change-Id: Ib6b332f0ec8e58989ef8c65ec30079d01fdf6c9a
> Signed-off-by: Anjali Singhai Jain <anjali.singhai@...el.com>
> Signed-off-by: Jesse Brandeburg <jesse.brandeburg@...el.com>
> Tested-by: Kavindya Deegala <kavindya.s.deegala@...el.com>
> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> ---
>  drivers/net/ethernet/intel/i40e/i40e_debugfs.c | 12 ++++++++++++
>  1 file changed, 12 insertions(+)
> 
> diff --git a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c
> index 9c675b5..3303b43 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_debugfs.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_debugfs.c
> @@ -1792,6 +1792,17 @@ static ssize_t i40e_dbg_command_write(struct file *filp,
>  		}
>  		kfree(buff);
>  		buff = NULL;
> +	} else if (strncmp(cmd_buf, "set rss_size", 12) == 0) {
> +		u16 queue_count;
> +		cnt = sscanf(&cmd_buf[12], "%hi", &queue_count);
> +		if (cnt != 1) {
> +			dev_info(&pf->pdev->dev,
> +				 "set rss_size: bad command string, cnt=%d\n", cnt);
> +			goto command_write_done;
> +		}
> +		dev_info(&pf->pdev->dev, " set rss_size requesting %d queues\n", queue_count);
> +		i40e_reconfig_rss_queues(pf, queue_count);
> +		dev_info(&pf->pdev->dev, " new rss_size %d\n", pf->rss_size);
>  	} else {
>  		dev_info(&pf->pdev->dev, "unknown command '%s'\n", cmd_buf);
>  		dev_info(&pf->pdev->dev, "available commands\n");
> @@ -1827,6 +1838,7 @@ static ssize_t i40e_dbg_command_write(struct file *filp,
>  		dev_info(&pf->pdev->dev, "  lldp event on\n");
>  		dev_info(&pf->pdev->dev, "  lldp event off\n");
>  		dev_info(&pf->pdev->dev, "  nvm read [module] [word_offset] [word_count]\n");
> +		dev_info(&pf->pdev->dev, "  set rss_size <count>\n");
>  	}
>  
>  command_write_done:

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html