netdev - Re: [PATCH] net: Cache route in IP tunnels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 12 Dec 2013 12:56:58 -0800
From:	Tom Herbert <therbert@...gle.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	David Miller <davem@...emloft.net>,
	Linux Netdev List <netdev@...r.kernel.org>
Subject: Re: [PATCH] net: Cache route in IP tunnels

On Thu, Dec 12, 2013 at 12:29 PM, Eric Dumazet <eric.dumazet@...il.com> wrote:
> On Thu, 2013-12-12 at 12:19 -0800, Tom Herbert wrote:
>
>> btw, I needed to disable gro on the tun interface. With it enabled,
>> performance in TCP_RR is abysmal. Looking into that.
>
> This is a known problem.
>
> Given that Jerry is working on GRO I was not really wanting to fix
> this...
>
> Thats a basically revert of
> ( http://git.kernel.org/cgit/linux/kernel/git/davem/net-next.git/commit/?id=693019e90ca45d881109d32c0c6d29adf03f6447 )

Reverting that patch doesn't fix the problem. We are hitting the
spinlock in gro_cells_receive a lot though.


> diff --git a/net/ipv4/ip_tunnel_core.c b/net/ipv4/ip_tunnel_core.c
> index 42ffbc8d65c6..dc7de784e934 100644
> --- a/net/ipv4/ip_tunnel_core.c
> +++ b/net/ipv4/ip_tunnel_core.c
> @@ -111,7 +111,6 @@ int iptunnel_pull_header(struct sk_buff *skb, int hdr_len, __be16 inner_proto)
>                 skb->rxhash = 0;
>         skb_dst_drop(skb);
>         skb->vlan_tci = 0;
> -       skb_set_queue_mapping(skb, 0);
>         skb->pkt_type = PACKET_HOST;
>         return 0;
>  }
>
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html