[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Thu, 12 Dec 2013 10:04:15 +0100
From: Maxime Ripard <maxime.ripard@...e-electrons.com>
To: srinivas kandagatla <srinivas.kandagatla@...com>
Cc: Chen-Yu Tsai <wens@...e.org>,
Giuseppe Cavallaro <peppe.cavallaro@...com>,
netdev <netdev@...r.kernel.org>,
Rob Herring <rob.herring@...xeda.com>,
devicetree <devicetree@...r.kernel.org>,
linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
linux-kernel <linux-kernel@...r.kernel.org>,
linux-sunxi <linux-sunxi@...glegroups.com>
Subject: Re: [PATCH 04/10] net: stmmac: sunxi platfrom extensions for GMAC in
Allwinner A20 SoC's
Hi,
On Wed, Dec 11, 2013 at 02:45:08PM +0000, srinivas kandagatla wrote:
> >>> 1. .tx_coe
> >>> This is not exported in the DT bindings.
> >>> Looking at stmmac code, not setting this seems to disable all
> >>> checksum offloading.
> >>
> >> Why cant this go via DT as well?
> >
> > If you and Giuseppe are OK with this, why not?
> Am Ok with it.
Please note that I'm opposed to this until someone explain why putting
it in the DT is relevant (and not just convenient).
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)
Powered by blists - more mailing lists