lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 14 Dec 2013 22:26:58 -0500 (EST) From: David Miller <davem@...emloft.net> To: rashika.kheria@...il.com Cc: linux-kernel@...r.kernel.org, sebastian@...akpoint.cc, sachin.kamat@...aro.org, netdev@...r.kernel.org, josh@...htriplett.org Subject: Re: [PATCH v2 5/9] drivers: net: Put prototype declaration for function sbni_probe() in sbni.c From: Rashika Kheria <rashika.kheria@...il.com> Date: Sat, 14 Dec 2013 17:55:42 +0530 > This patch declares the prototype for the function sbni_probe() in file sbni.c. > > Thus, it also removes the following warning in wan/sbni.c: > drivers/net/wan/sbni.c:224:12: warning: no previous prototype for ‘sbni_probe’ [-Wmissing-prototypes] > > Signed-off-by: Rashika Kheria <rashika.kheria@...il.com> > --- > > This revision fixes the following issues of the previous revision: > Incorrect fix > > drivers/net/wan/sbni.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/wan/sbni.c b/drivers/net/wan/sbni.c > index 388ddf6..5061ffd 100644 > --- a/drivers/net/wan/sbni.c > +++ b/drivers/net/wan/sbni.c > @@ -221,6 +221,7 @@ static void __init sbni_devsetup(struct net_device *dev) > dev->netdev_ops = &sbni_netdev_ops; > } > > +int __init sbni_probe(int unit); > int __init sbni_probe(int unit) This is not the correct way to fix this kind of warning, an exported function needs to appear in a header file so that both the definition and any callers of this function will see the same declaration in that header file.
Powered by blists - more mailing lists