netdev - Re: [PATCH 2/8] b44: rename B44_PHY_ADDR_NO_PHY to B44_PHY_ADDR_NO_LOCAL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 16 Dec 2013 15:51:45 +0000
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Hauke Mehrtens <hauke@...ke-m.de>
CC:	<davem@...emloft.net>, <zambrano@...adcom.com>,
	<netdev@...r.kernel.org>
Subject: Re: [PATCH 2/8] b44: rename B44_PHY_ADDR_NO_PHY to
 B44_PHY_ADDR_NO_LOCAL_PHY

On Sun, 2013-12-15 at 19:41 +0100, Hauke Mehrtens wrote:
> The PHY address 30 means there is no local PHY, but there could be an
> external PHY like a switch connected via MII. This is the case on most
> embedded home routers where this driver is used.
> 
> Signed-off-by: Hauke Mehrtens <hauke@...ke-m.de>
> ---
>  drivers/net/ethernet/broadcom/b44.c |    2 +-
>  drivers/net/ethernet/broadcom/b44.h |    6 +++---
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/net/ethernet/broadcom/b44.c b/drivers/net/ethernet/broadcom/b44.c
> index 3c7909e..fce36dd 100644
> --- a/drivers/net/ethernet/broadcom/b44.c
> +++ b/drivers/net/ethernet/broadcom/b44.c
> @@ -2237,7 +2237,7 @@ static int b44_init_one(struct ssb_device *sdev,
>  
>  	/* do a phy reset to test if there is an active phy */
>  	if (b44_phy_reset(bp) < 0)
> -		bp->phy_addr = B44_PHY_ADDR_NO_PHY;
> +		bp->phy_addr = B44_PHY_ADDR_NO_LOACL_PHY;

LOACL?

>  	netdev_info(dev, "%s %pM\n", DRV_DESCRIPTION, dev->dev_addr);
>  
> diff --git a/drivers/net/ethernet/broadcom/b44.h b/drivers/net/ethernet/broadcom/b44.h
> index 8ed7d6b..ade80d6 100644
> --- a/drivers/net/ethernet/broadcom/b44.h
> +++ b/drivers/net/ethernet/broadcom/b44.h
> @@ -280,9 +280,9 @@ struct ring_info {
>  	dma_addr_t	mapping;
>  };
>  
> -#define B44_MCAST_TABLE_SIZE	32
> -#define B44_PHY_ADDR_NO_PHY	30
> -#define B44_MDC_RATIO		5000000
> +#define B44_MCAST_TABLE_SIZE		32
> +#define B44_PHY_ADDR_NO_LOACL_PHY	30 /* no local phy regs */
> +#define B44_MDC_RATIO			5000000
>  
>  #define	B44_STAT_REG_DECLARE		\
>  	_B44(tx_good_octets)		\

At least it's spelt consistently wrongly. :-)

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html