netdev - Re: [PATCH net-next 9/10] lro: remove unused code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 16 Dec 2013 19:54:27 +0000
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Stephen Hemminger <stephen@...workplumber.org>
CC:	David Miller <davem@...emloft.net>, <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next 9/10] lro: remove unused code

On Mon, 2013-12-16 at 10:45 -0800, Stephen Hemminger wrote:
> This code is not used anywhere in net-next
> 
> Signed-off-by: Stephen Hemminger <stephen@...workplumber.org>
[...]
> --- a/net/ipv4/inet_lro.c	2013-10-06 14:48:24.966449847 -0700
> +++ b/net/ipv4/inet_lro.c	2013-12-12 13:28:43.435225437 -0800
> @@ -506,23 +506,6 @@ void lro_receive_skb(struct net_lro_mgr
>  }
>  EXPORT_SYMBOL(lro_receive_skb);
>  
> -void lro_receive_frags(struct net_lro_mgr *lro_mgr,
> -		       struct skb_frag_struct *frags,
> -		       int len, int true_size, void *priv, __wsum sum)
> -{
> -	struct sk_buff *skb;
> -
> -	skb = __lro_proc_segment(lro_mgr, frags, len, true_size, priv, sum);

You should remove unused functions recursively.  After this, you can
remove at least __lro_proc_segment(), lro_gen_skb() and lro_add_frags().

> -	if (!skb)
> -		return;
> -
> -	if (lro_mgr->features & LRO_F_NAPI)
> -		netif_receive_skb(skb);
> -	else
> -		netif_rx(skb);
> -}
> -EXPORT_SYMBOL(lro_receive_frags);
> -
>  void lro_flush_all(struct net_lro_mgr *lro_mgr)
>  {
>  	int i;
> @@ -534,14 +517,3 @@ void lro_flush_all(struct net_lro_mgr *l
>  	}
>  }
>  EXPORT_SYMBOL(lro_flush_all);
> -
> -void lro_flush_pkt(struct net_lro_mgr *lro_mgr,
> -		  struct iphdr *iph, struct tcphdr *tcph)
> -{
> -	struct net_lro_desc *lro_desc;
> -
> -	lro_desc = lro_get_desc(lro_mgr, lro_mgr->lro_arr, iph, tcph);
> -	if (lro_desc->active)
> -		lro_flush(lro_mgr, lro_desc);
> -}
> -EXPORT_SYMBOL(lro_flush_pkt);

It looks like lro_flush_pkt() was *never* used!

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html