netdev - Re: [PATCH net-next V1 10/11] net/mlx4_en: Fix Supported/Advertised link mode reported by ethtool

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 17 Dec 2013 15:46:54 +0000
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Amir Vadai <amirv@...lanox.com>
CC:	"David S. Miller" <davem@...emloft.net>,
	Or Gerlitz <ogerlitz@...lanox.com>,
	Yevgeny Petrilin <yevgenyp@...lanox.com>,
	<netdev@...r.kernel.org>, Rana Shahout <ranas@...lanox.com>,
	"Eugenia Emantayev" <eugenia@...lanox.co.il>,
	Eyal Perry <eyalpe@...lanox.com>
Subject: Re: [PATCH net-next V1 10/11] net/mlx4_en: Fix Supported/Advertised
 link mode reported by ethtool

On Tue, 2013-12-17 at 09:01 +0200, Amir Vadai wrote:
> From: Rana Shahout <ranas@...lanox.com>
> 
> Correctly report the support for 1/10/40Gbps link-speed as
> supported/advertised link mode in ethtool's get_settings command.
[...]
> +	cmd->supported = SUPPORTED_1000baseT_Full |
> +		SUPPORTED_10000baseT_Full |
> +		SUPPORTED_1000baseKX_Full |
> +		SUPPORTED_10000baseKX4_Full |
> +		SUPPORTED_10000baseKR_Full |
> +		SUPPORTED_10000baseR_FEC |
> +		SUPPORTED_40000baseKR4_Full |
> +		SUPPORTED_40000baseCR4_Full |
> +		SUPPORTED_40000baseSR4_Full |
> +		SUPPORTED_40000baseLR4_Full;
> +
> +	cmd->advertising = ADVERTISED_1000baseT_Full |
> +		ADVERTISED_10000baseT_Full |
> +		ADVERTISED_1000baseKX_Full |
> +		ADVERTISED_10000baseKX4_Full |
> +		ADVERTISED_10000baseKR_Full |
> +		ADVERTISED_10000baseR_FEC |
> +		ADVERTISED_40000baseKR4_Full |
> +		ADVERTISED_40000baseCR4_Full |
> +		ADVERTISED_40000baseSR4_Full |
> +		ADVERTISED_40000baseLR4_Full;
[...]

How is this correct?  You should report the actual capabilities of the
MAC and PHY are present, not the union of all possible modes of all the
supported boards.

(And the Kconfig description for MLX4_EN says '10Gbit Ethernet support',
so if this driver now supports some 40G boards that should be updated.)

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html