| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 17 Dec 2013 16:22:32 +1100 From: David Gibson <david@...son.dropbear.id.au> To: manish.chopra@...gic.com, sony.chacko@...gic.com, rajesh.borundia@...gic.com Cc: netdev@...r.kernel.org, snagarka@...hat.com, tcamuso@...hat.com, vdasgupt@...hat.com, David Gibson <david@...son.dropbear.id.au> Subject: [PATCH 1/2] netxen: Correct off-by-one error in bounds check After retrieving an Rx buffer index from the hardware, the netxen driver bounds checks it against its array of receive buffers. However in the case of LRO packets, there's an off-by-one error in the check - it uses > instead of the >= it uses for the normal receive path in netxen_process_rcv(). Signed-off-by: David Gibson <david@...son.dropbear.id.au> --- drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c b/drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c index 7692dfd..68658b8 100644 --- a/drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c +++ b/drivers/net/ethernet/qlogic/netxen/netxen_nic_init.c @@ -1610,7 +1610,7 @@ netxen_process_lro(struct netxen_adapter *adapter, rds_ring = &recv_ctx->rds_rings[ring]; index = netxen_get_lro_sts_refhandle(sts_data0); - if (unlikely(index > rds_ring->num_desc)) + if (unlikely(index >= rds_ring->num_desc)) return NULL; buffer = &rds_ring->rx_buf_arr[index]; -- 1.8.3.1 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists