netdev - RE: [PATCH v3 1/8] drivers: net: Mark functions as static in qlcnic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 19 Dec 2013 11:49:50 +0000
From:	Shahed Shaikh <shahed.shaikh@...gic.com>
To:	Rashika Kheria <rashika.kheria@...il.com>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Himanshu Madhani <himanshu.madhani@...gic.com>,
	Rajesh Borundia <rajesh.borundia@...gic.com>,
	Jitendra Kalsaria <jitendra.kalsaria@...gic.com>,
	Sony Chacko <sony.chacko@...gic.com>,
	Sucheta Chakraborty <sucheta.chakraborty@...gic.com>,
	Dept-Eng Linux Driver <Linux-Driver@...gic.com>,
	netdev <netdev@...r.kernel.org>,
	"josh@...htriplett.org" <josh@...htriplett.org>
Subject: RE: [PATCH v3 1/8] drivers: net: Mark functions as static in
 qlcnic_io.c

> -----Original Message-----
> From: netdev-owner@...r.kernel.org [mailto:netdev-
> owner@...r.kernel.org] On Behalf Of Rashika Kheria
> Sent: Thursday, December 19, 2013 2:17 PM
> To: linux-kernel; Himanshu Madhani; Rajesh Borundia; Shahed Shaikh;
> Jitendra Kalsaria; Sony Chacko; Sucheta Chakraborty; Dept-Eng Linux Driver;
> netdev; josh@...htriplett.org
> Subject: [PATCH v3 1/8] drivers: net: Mark functions as static in qlcnic_io.c
> 
> This patch marks the function qlcnic_enable_tx_intr(),
> qlcnic_83xx_enable_tx_intr() and qlcnic_83xx_disable_tx_intr() in qlcnic_io.c
> as static because they are not used outside this file.
> 
> Thus, it also removes the following warnings in
> ethernet/qlogic/qlcnic/qlcnic_io.c:
> 
> drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c:130:13: warning: no previous
> prototype for ‘qlcnic_enable_tx_intr’ [-Wmissing-prototypes]
> drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c:147:13: warning: no previous
> prototype for ‘qlcnic_83xx_enable_tx_intr’ [-Wmissing-prototypes]
> drivers/net/ethernet/qlogic/qlcnic/qlcnic_io.c:153:13: warning: no previous
> prototype for ‘qlcnic_83xx_disable_tx_intr’ [-Wmissing-prototypes]
> 
> Signed-off-by: Rashika Kheria <rashika.kheria@...il.com>
> Reviewed-by: Josh Triplett <josh@...htriplett.org>

Acked-by: Shahed Shaikh <shahed.shaikh@...gic.com>

Thanks,
Shahed