netdev - Re: [net-next 06/15] i40e: Rx checksum offload for VXLAN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 19 Dec 2013 11:17:30 -0800
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Or Gerlitz <or.gerlitz@...il.com>
Cc:	David Miller <davem@...emloft.net>,
	Joseph Gasparakis <joseph.gasparakis@...el.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"gospo@...hat.com" <gospo@...hat.com>, sassmann@...hat.com,
	Jesse Brandeburg <jesse.brandeburg@...el.com>
Subject: Re: [net-next 06/15] i40e: Rx checksum offload for VXLAN

On Thu, 2013-12-19 at 19:46 +0200, Or Gerlitz wrote:
> On Thu, Dec 19, 2013 at 8:34 AM, Jeff Kirsher
> <jeffrey.t.kirsher@...el.com> wrote:
> > From: Joseph Gasparakis <joseph.gasparakis@...el.com>
> >
> > This implements receive offload for VXLAN for i40e.  The hardware
> > supports checksum offload/verification of the inner/outer header.
> >
> > Change-Id: I450db300af6713f2044fef1191a0d1d294c13369
> > Signed-off-by: Joseph Gasparakis <joseph.gasparakis@...el.com>
> > Signed-off-by: Jesse Brandeburg <jesse.brandeburg@...el.com>
> > Tested-by: Kavindya Deegala <kavindya.s.deegala@...el.com>
> > Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
> > ---
> >  drivers/net/ethernet/intel/i40e/i40e.h      |  1 +
> >  drivers/net/ethernet/intel/i40e/i40e_main.c |  2 ++
> >  drivers/net/ethernet/intel/i40e/i40e_txrx.c | 56
> ++++++++++++++++++++++++++---
> >  drivers/net/ethernet/intel/i40e/i40e_type.h | 51
> ++++++++++++++------------
> >  4 files changed, 82 insertions(+), 28 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/intel/i40e/i40e.h
> b/drivers/net/ethernet/intel/i40e/i40e.h
> > index 31dd265..3207568 100644
> > --- a/drivers/net/ethernet/intel/i40e/i40e.h
> > +++ b/drivers/net/ethernet/intel/i40e/i40e.h
> > @@ -29,6 +29,7 @@
> >  #define _I40E_H_
> >
> >  #include <net/tcp.h>
> > +#include <net/udp.h>
> >  #include <linux/init.h>
> >  #include <linux/types.h>
> >  #include <linux/errno.h>
> > diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c
> b/drivers/net/ethernet/intel/i40e/i40e_main.c
> > index b0cfb4c..7094ff7 100644
> > --- a/drivers/net/ethernet/intel/i40e/i40e_main.c
> > +++ b/drivers/net/ethernet/intel/i40e/i40e_main.c
> > @@ -27,6 +27,7 @@
> >
> >  /* Local includes */
> >  #include "i40e.h"
> > +#include <net/vxlan.h>
> >
> >  const char i40e_driver_name[] = "i40e";
> >  static const char i40e_driver_string[] =
> > @@ -3993,6 +3994,7 @@ static int i40e_open(struct net_device
> *netdev)
> >                                     "couldn't set broadcast err %d
> aq_err %d\n",
> >                                     err, pf->hw.aq.asq_last_status);
> >         }
> > +       vxlan_get_rx_port(netdev);
> 
> what effect this has if  the driver doesn't implement the
> add_vxlan_port ndo entry?

It appears that there should have been a VXLAN for i40e from Joseph that
got pushed before this one, so I will re-send this series with necessary
patch added to the series.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)