lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 19 Dec 2013 11:30:09 +0800 From: Fan Du <fan.du@...driver.com> To: Pablo Neira Ayuso <pablo@...filter.org> CC: <davem@...emloft.net>, <steffen.klassert@...unet.com>, <netfilter-devel@...r.kernel.org>, <netdev@...r.kernel.org> Subject: Re: [PATCH net-next 0/2] netfilter: IPv4/v6 IPcomp match support On 2013年12月17日 21:05, Pablo Neira Ayuso wrote: > On Fri, Dec 13, 2013 at 08:18:00PM +0800, Fan Du wrote: >> Hi, >> >> This patchset adds IPv4/v6 IPComp 'match' plugin to enables user setting >> ACTONs for IPcomp flows sepecified with SPI value. >> >> Corresponding iptables patchset will be sent here after soon. >> >> Fan Du (2): >> netfilter: add IPv4 IPComp extension match support >> netfilter: add IPv6 IPComp extension match support > > This looks good, but I have to ask you to merge those two modules into > one single xt_ipcomp, they are fairly small and we can save the > overhead of having two different modules. Moreover, at quick glance I > don't see any dependency with IPv4/IPv6 exported symbols that may > cause ifdef pollution. > > Please, see net/netfilter/xt_tcpudp.c as reference to rework this. > Thanks. > I noticed netfilter ipv4/v6 AH support also has split implementation, so far, by my understanding, it's fairly enough to consolidate those two implementations into one as well, as IPv4/6 AH head format are identical. If you don't mind or it won't break anything internal for netfilter, I plan to combine them into one piece. -- 浮沉随浪只记今朝笑 --fan -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists