netdev - Re: [patch net-next 6/7] ipv4: ERROR: code indent should use tabs where possible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 20 Dec 2013 17:53:06 +0000
From:	Ben Hutchings <bhutchings@...arflare.com>
To:	Chen Weilong <chenweilong@...wei.com>
CC:	<davem@...emloft.net>, <kuznet@....inr.ac.ru>, <jmorris@...ei.org>,
	<yoshfuji@...ux-ipv6.org>, <kaber@...sh.net>,
	<steffen.klassert@...unet.com>, <herbert@...dor.apana.org.au>,
	<netdev@...r.kernel.org>, <netfilter-devel@...r.kernel.org>,
	<netfilter@...r.kernel.org>
Subject: Re: [patch net-next 6/7] ipv4: ERROR: code indent should use tabs
 where possible

On Fri, 2013-12-20 at 19:57 +0800, Chen Weilong wrote:
> From: Weilong Chen <chenweilong@...wei.com>
> 
> 
> Signed-off-by: Weilong Chen <chenweilong@...wei.com>
> ---
>  net/ipv4/cipso_ipv4.c      | 6 +++---
>  net/ipv4/sysctl_net_ipv4.c | 2 +-
>  net/ipv4/xfrm4_mode_beet.c | 2 +-
>  3 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/net/ipv4/cipso_ipv4.c b/net/ipv4/cipso_ipv4.c
> index 4b59b6e..081f51a 100644
> --- a/net/ipv4/cipso_ipv4.c
> +++ b/net/ipv4/cipso_ipv4.c
> @@ -1336,7 +1336,7 @@ static int cipso_v4_parsetag_rbm(const struct cipso_v4_doi *doi_def,
>  
>  	if (tag_len > 4) {
>  		secattr->attr.mls.cat =
> -		                       netlbl_secattr_catmap_alloc(GFP_ATOMIC);
> +				       netlbl_secattr_catmap_alloc(GFP_ATOMIC);
>  		if (secattr->attr.mls.cat == NULL)
>  			return -ENOMEM;
>  
> @@ -1432,7 +1432,7 @@ static int cipso_v4_parsetag_enum(const struct cipso_v4_doi *doi_def,
>  
>  	if (tag_len > 4) {
>  		secattr->attr.mls.cat =
> -			               netlbl_secattr_catmap_alloc(GFP_ATOMIC);
> +				       netlbl_secattr_catmap_alloc(GFP_ATOMIC);
>  		if (secattr->attr.mls.cat == NULL)
>  			return -ENOMEM;
>  
> @@ -1527,7 +1527,7 @@ static int cipso_v4_parsetag_rng(const struct cipso_v4_doi *doi_def,
>  
>  	if (tag_len > 4) {
>  		secattr->attr.mls.cat =
> -			               netlbl_secattr_catmap_alloc(GFP_ATOMIC);
> +				       netlbl_secattr_catmap_alloc(GFP_ATOMIC);
>  		if (secattr->attr.mls.cat == NULL)
>  			return -ENOMEM;
>  
[...]

These lines are still excessively indented (one extra tab is enough),
and could just be appended to the lines above them:

		secattr->attr.mls.cat = netlbl_secattr_catmap_alloc(GFP_ATOMIC);

(exactly 80 columns long).

Ben.

-- 
Ben Hutchings, Staff Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html