netdev - Re: [PATCH net-next 2/2] netlink: specify netlink packet direction for nlmon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 23 Dec 2013 01:06:24 +0100
From:	Daniel Borkmann <dborkman@...hat.com>
To:	David Miller <davem@...emloft.net>
CC:	netdev@...r.kernel.org, darkjames-ws@...kjames.pl
Subject: Re: [PATCH net-next 2/2] netlink: specify netlink packet direction
 for nlmon

On 12/23/2013 12:56 AM, David Miller wrote:
> From: Daniel Borkmann <dborkman@...hat.com>
> Date: Thu, 19 Dec 2013 02:29:39 +0100
>
>> @@ -29,6 +29,9 @@ struct sockaddr_ll {
>>   /* These ones are invisible by user level */
>>   #define PACKET_LOOPBACK		5		/* MC/BRD frame looped back */
>>   #define PACKET_FASTROUTE	6		/* Fastrouted frame	*/
>> +/* These ones are for nlmon devices */
>> +#define PACKET_USER		0		/* To user space */
>> +#define PACKET_KERNEL		1		/* To kernel space */
>
> I know it is tempting to do so, but please do not reuse values
> like this.

Hm, ok. As we only have 3 bits for all this, are you okay with
doing the following ...

#define PACKET_USER	6	/* To user space   */
#define PACKET_KERNEL	7	/* To kernel space */

PACKET_FASTROUTE isn't used anywhere in the tree, only defined
in this header file. Then, by doing this, we would still fit.

> THanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html