netdev - Re: [PATCH 1/6] batman-adv: free nf_bridge member on locally delivered skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 23 Dec 2013 01:19:10 +0100
From:	Antonio Quartulli <antonio@...hcoding.com>
To:	David Miller <davem@...emloft.net>
CC:	netdev@...r.kernel.org, b.a.t.m.a.n@...ts.open-mesh.org,
	mareklindner@...mailbox.ch
Subject: Re: [PATCH 1/6] batman-adv: free nf_bridge member on locally delivered
 skb

On 23/12/13 01:16, David Miller wrote:
> There is zero reason for your protocol layer to have an ad-hoc private
> SKB netfilter state reset function that touches internals in this way.
> 

agreed.

> At least with the generic helpers, we know the side effects and the
> function is well known to other developers.
> 


Ok, I'll do it the clean way and resend the pull request.


Thanks!

-- 
Antonio Quartulli


Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)