lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 25 Dec 2013 00:45:18 +0300 From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com> To: Simon Horman <horms+renesas@...ge.net.au>, "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org, linux-sh@...r.kernel.org CC: Magnus Damm <magnus.damm@...il.com> Subject: Re: [PATCH RFC 3/3] [RFC] ARM: shmobile: genmai: Enable r7s72100-gether Hello. On 12/15/2013 11:24 AM, Simon Horman wrote: > --- > arch/arm/mach-shmobile/board-genmai.c | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > diff --git a/arch/arm/mach-shmobile/board-genmai.c b/arch/arm/mach-shmobile/board-genmai.c > index 3e92e3c..838325b 100644 > --- a/arch/arm/mach-shmobile/board-genmai.c > +++ b/arch/arm/mach-shmobile/board-genmai.c > @@ -20,15 +20,35 @@ > > #include <linux/kernel.h> > #include <linux/platform_device.h> > +#include <linux/sh_eth.h> > #include <mach/common.h> > +#include <mach/irqs.h> > #include <mach/r7s72100.h> > #include <asm/mach-types.h> > #include <asm/mach/arch.h> > > +/* GEther */ Just Ether. > +static const struct sh_eth_plat_data gether_pdata __initconst = { > + .phy = 0x00, /* PD60610 */ > + .edmac_endian = EDMAC_LITTLE_ENDIAN, > + .phy_interface = PHY_INTERFACE_MODE_MII, I think .no_ether_link should be set to 1 -- I don't see the LINK signal in the manual. > +}; > + > +static const struct resource gether_resources[] __initconst = { > + DEFINE_RES_MEM(0xe8203000, 0x800), > + DEFINE_RES_MEM(0xe8204800, 0x200), > + DEFINE_RES_IRQ(gic_iid(359)), > +}; > + > static void __init genmai_add_standard_devices(void) > { > r7s72100_clock_init(); > r7s72100_add_dt_devices(); > + > + platform_device_register_resndata(&platform_bus, "r7s72100-gether", -1, We can't call it "-gether" if it lacks 1000 Mbps support. And the manual explicitly calls it ETHER. WBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists