netdev - Re: [PATCH net-next RESEND v3] tipc: make the code look more readable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 27 Dec 2013 12:21:04 +0800
From:	Wang Weidong <wangweidong1@...wei.com>
To:	David Miller <davem@...emloft.net>
CC:	<jon.maloy@...csson.com>, <allan.stephens@...driver.com>,
	<David.Laight@...LAB.COM>, <netdev@...r.kernel.org>,
	<sergei.shtylyov@...entembedded.com>, <ying.xue@...driver.com>
Subject: Re: [PATCH net-next RESEND v3] tipc: make the code look more readable

On 2013/12/27 12:04, David Miller wrote:
> 
> You need to resubmit patch #1 along with this one, not just this
> one by itself.
> 
> Thanks.
> 
> 
As Ying pointed out that the patch #1 ("tipc: make the code look more better")
does not provide any value. something like below:

Actually the original logic seems better understandable for us because
it immediately lets us know how to do if "tp_ptr->connected" is true.
Instead the patch has a little negative effect on performance because
"tp_ptr->connected" is true in most time.

So I drop the patch #1. Now only this patch.

Regards,
Wang

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html