netdev - Re: [PATCH 2/2] ixgbe: set driver_max_VFs should be done before enabling SRIOV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 27 Dec 2013 01:03:23 -0800
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Ethan Zhao <ethan.kernel@...il.com>
Cc:	jesse.brandeburg@...el.com, bruce.w.allan@...el.com,
	carolyn.wyborny@...el.com, davem@...emloft.net,
	e1000-devel@...ts.sourceforge.net, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] ixgbe: set driver_max_VFs should be done before
 enabling SRIOV

On Wed, 2013-12-25 at 00:07 +0800, Ethan Zhao wrote:
> commit 43dc4e01 Limit number of reported VFs to device specific value
> It doesn't work and always returns -EBUSY because VFs ware already
> enabled.
> 
> ixgbe_enable_sriov()
>         pci_enable_sriov()
>                 sriov_enable()
>                 {
>                 ... ..
>                 iov->ctrl |= PCI_SRIOV_CTRL_VFE | PCI_SRIOV_CTRL_MSE;
>                 pci_cfg_access_lock(dev);
>                 ... ...
>                 }
> 
> pci_sriov_set_totalvfs()
> {
> ... ...
> if (dev->sriov->ctrl & PCI_SRIOV_CTRL_VFE)
>                 return -EBUSY;
> ...
> }
> 
> So should set driver_max_VFs with pci_sriov_set_totalvfs() before
> enable VFs with ixgbe_enable_sriov().
> 
> Signed-off-by: Ethan Zhao <ethan.kernel@...il.com>
> ---
>  drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Thanks Ethan, I have added this patch as well to my queue.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)