netdev - Re: [PATCH] phy: IRQ cannot be shared

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 27 Dec 2013 13:43:33 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	f.fainelli@...il.com
Cc:	sergei.shtylyov@...entembedded.com, netdev@...r.kernel.org
Subject: Re: [PATCH] phy: IRQ cannot be shared

From: Florian Fainelli <f.fainelli@...il.com>
Date: Fri, 20 Dec 2013 10:24:05 -0800

> 2013/12/20 Sergei Shtylyov <sergei.shtylyov@...entembedded.com>:
>> With the way PHY IRQ handler is implemented (all real handling being pushed to
>> the workqueue and returning IRQ_HANDLED all the time PHY is active), we cannot
>> really claim that PHY IRQ can be shared when calling request_irq().
> 
> Looks good, in the future we might want to be able to let the Ethernet
> MAC driver specify the flags to pass down to request_irq() but this is
> good enough for me for the time being.
> 
>>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
> 
> Acked-by: Florian Fainelli <f.fainelli@...il.com>

I really worry that putting this new restriction in place is going to
break a bunch of drivers.

Arguably they are broken, but they are least mostly working right now
and probes will completely fail after this change.

Feel free to allay my concerns, but tossing this into 'net' and
-stable with such a possible risk really concerns me.

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html