lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 02 Jan 2014 19:34:07 -0500 (EST) From: David Miller <davem@...emloft.net> To: sergei.shtylyov@...entembedded.com Cc: netdev@...r.kernel.org, linux-sh@...r.kernel.org Subject: Re: [PATCH] sh_eth: coding style fixes From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com> Date: Tue, 31 Dec 2013 03:25:21 +0300 > @@ -1952,8 +1949,8 @@ static void sh_eth_tx_timeout(struct net > netif_stop_queue(ndev); > > if (netif_msg_timer(mdp)) > - dev_err(&ndev->dev, "%s: transmit timed out, status %8.8x," > - " resetting...\n", ndev->name, (int)sh_eth_read(ndev, EESR)); > + dev_err(&ndev->dev, "%s: transmit timed out, status %8.8x, resetting...\n" > + ndev->name, (int)sh_eth_read(ndev, EESR)); > > /* tx_errors count up */ > ndev->stats.tx_errors++; You did not build test this. drivers/net/ethernet/renesas/sh_eth.c: In function ‘sh_eth_tx_timeout’: drivers/net/ethernet/renesas/sh_eth.c:1953:4: error: expected ‘)’ before ‘ndev’ drivers/net/ethernet/renesas/sh_eth.c:1953:4: warning: format ‘%s’ expects a matching ‘char *’ argument [-Wformat] drivers/net/ethernet/renesas/sh_eth.c:1953:4: warning: format ‘%x’ expects a matching ‘unsigned int’ argument [-Wformat]
Powered by blists - more mailing lists