netdev - Re: [PATCH 4/6] phy: kill excess code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 04 Jan 2014 19:29:35 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Richard Cochran <richardcochran@...il.com>
CC:	netdev@...r.kernel.org
Subject: Re: [PATCH 4/6] phy: kill excess code

Hello.

On 01/04/2014 10:36 AM, Richard Cochran wrote:

>> Remove tens of lines of unnecessary code:

>> - kill empty lines between a function call and its result check;

> ...

>> - kill excess empty lines.

> Blank lines are not LOC. They can improve legibility.

    Both kinds of empty lines are consistently avoided by all other code I had 
to read. They don't really improve anything.

> Thanks,
> Richard

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html