lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 8 Jan 2014 00:16:14 +0000 From: "Brown, Aaron F" <aaron.f.brown@...el.com> To: Julia Lawall <Julia.Lawall@...6.fr>, "Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "e1000-devel@...ts.sourceforge.net" <e1000-devel@...ts.sourceforge.net> CC: "Brandeburg, Jesse" <jesse.brandeburg@...el.com>, "Allan, Bruce W" <bruce.w.allan@...el.com>, "Wyborny, Carolyn" <carolyn.wyborny@...el.com>, "Skidmore, Donald C" <donald.c.skidmore@...el.com>, "Rose, Gregory V" <gregory.v.rose@...el.com>, "Duyck, Alexander H" <alexander.h.duyck@...el.com>, "Ronciak, John" <john.ronciak@...el.com> Subject: RE: [PATCH] ixgbevf: delete unneeded call to pci_set_power_state > From: netdev-owner@...r.kernel.org [mailto:netdev-owner@...r.kernel.org] > On Behalf Of Julia Lawall > Sent: Tuesday, January 07, 2014 9:00 AM > To: Kirsher, Jeffrey T > Cc: kernel-janitors@...r.kernel.org; Brandeburg, Jesse; Allan, Bruce W; > Wyborny, Carolyn; Skidmore, Donald C; Rose, Gregory V; Duyck, Alexander H; > Ronciak, John; e1000-devel@...ts.sourceforge.net; netdev@...r.kernel.org; > linux-kernel@...r.kernel.org > Subject: [PATCH] ixgbevf: delete unneeded call to pci_set_power_state > > From: Julia Lawall <Julia.Lawall@...6.fr> > > This driver does not need to adjust the power state on suspend, so the > call to pci_set_power_state in the resume function is a no-op. Drop it, > to make the code more understandable. > > Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr> > > --- > drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c > b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c > index a5d3167..5709fb0 100644 > --- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c > +++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c > @@ -3226,7 +3226,6 @@ static int ixgbevf_resume(struct pci_dev *pdev) > struct net_device *netdev = adapter->netdev; > u32 err; > > - pci_set_power_state(pdev, PCI_D0); > pci_restore_state(pdev); > /* > * pci_restore_state clears dev->state_saved so call > > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in the > body of a message to majordomo@...r.kernel.org More majordomo info at > http://vger.kernel.org/majordomo-info.html Thanks Julia, I have added this patch to our internal queue (covering for Jeff.) -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists