lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 9 Jan 2014 09:22:17 +0000 From: Paul Durrant <Paul.Durrant@...rix.com> To: Eric Dumazet <eric.dumazet@...il.com> CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "xen-devel@...ts.xen.org" <xen-devel@...ts.xen.org>, David Miller <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Veaceslav Falico <vfalico@...hat.com>, Alexander Duyck <alexander.h.duyck@...el.com>, Nicolas Dichtel <nicolas.dichtel@...nd.com> Subject: RE: [PATCH net-next 1/3] net: add skb_checksum_setup > -----Original Message----- > From: Eric Dumazet [mailto:eric.dumazet@...il.com] > Sent: 08 January 2014 22:43 > To: Paul Durrant > Cc: netdev@...r.kernel.org; xen-devel@...ts.xen.org; David Miller; Eric > Dumazet; Veaceslav Falico; Alexander Duyck; Nicolas Dichtel > Subject: Re: [PATCH net-next 1/3] net: add skb_checksum_setup > > On Wed, 2014-01-08 at 13:58 +0000, Paul Durrant wrote: > > This patch adds a function to set up the partial checksum offset for IP > > packets (and optionally re-calculate the pseudo-header checksum) into the > > core network code. > > The implementation was previously private and duplicated between xen- > netback > > and xen-netfront, however it is not xen-specific and is potentially useful > > to any network driver. > > > > Signed-off-by: Paul Durrant <paul.durrant@...rix.com> > > Cc: David Miller <davem@...emloft.net> > > Cc: Eric Dumazet <edumazet@...gle.com> > > Cc: Veaceslav Falico <vfalico@...hat.com> > > Cc: Alexander Duyck <alexander.h.duyck@...el.com> > > Cc: Nicolas Dichtel <nicolas.dichtel@...nd.com> > > --- > > include/linux/netdevice.h | 1 + > > net/core/dev.c | 271 > +++++++++++++++++++++++++++++++++++++++++++++ > > 2 files changed, 272 insertions(+) > > Is there any reason to put this in net/core/dev.c instead of > net/core/skbuff.c ? > No, no reason. I just wasn't sure which was the better place. I'll put it in skbuff.c if that is more appropriate. > > Also, no inline should be used in a .c file > > ( skb_maybe_pull_tail ) > Ok. I'll fix that. Thanks, Paul
Powered by blists - more mailing lists