netdev - Re: [PATCH net-next] bonding: move the netdev_add_tso

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 19 Jan 2014 13:34:21 +0800
From:	Ding Tianhong <dingtianhong@...wei.com>
To:	Eric Dumazet <eric.dumazet@...il.com>,
	Veaceslav Falico <vfalico@...hat.com>
CC:	Jay Vosburgh <fubar@...ibm.com>,
	Eric Dumazet <edumazet@...gle.com>,
	"David S. Miller" <davem@...emloft.net>,
	Netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net-next] bonding: move the netdev_add_tso_features()
 to bonding module

On 2014/1/19 1:08, Eric Dumazet wrote:
> On Sat, 2014-01-18 at 12:48 +0100, Veaceslav Falico wrote:
>> On Sat, Jan 18, 2014 at 04:31:33PM +0800, Ding Tianhong wrote:
>>> The function netdev_add_tso_features() was only be used for bonding,
>>> so no need to export it in netdevice.h, move it to bonding module.
>>
>> Eric added it for a reason - like, other drivers might use it. Do you know
>> if team, bridge, vlan etc. might use it?
> 
> A helper can be used once, this is fine. A car can have 4 seats, and can
> even be used with no passenger.
> 
> I am quite bored by patches that break clean layering for wrong reasons.
> 
> 
> static inline netdev_features_t netdev_add_tso_features(netdev_features_t features,
>                                                       netdev_features_t mask)
> {
>       return netdev_increment_features(features, NETIF_F_ALL_TSO, mask);
> }
> 
> There is _nothing_ in this helper that implies it should be private to bonding.
> 
> 

yep, it is look so fool that my patch said, thanks for reminding me.

> 
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html