lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 20 Jan 2014 12:47:13 +0100
From: Marc Kleine-Budde <mkl@...gutronix.de>
To: Geert Uytterhoeven <geert@...ux-m68k.org>,
Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
wg@...ndegger.com, linux-can@...r.kernel.org,
Linux-sh list <linux-sh@...r.kernel.org>, vksavl@...il.com
Subject: Re: [PATCH v5] can: add Renesas R-Car CAN driver
On 01/20/2014 12:43 PM, Geert Uytterhoeven wrote:
> Hi Sergei,
>
> On Thu, Dec 26, 2013 at 10:37 PM, Sergei Shtylyov
> <sergei.shtylyov@...entembedded.com> wrote:
>> Changes in version 3:
>
>> - added '__packed' to 'struct rcar_can_mbox_regs' and 'struct rcar_can_regs';
>> - removed unneeded type cast in the probe() method.
>
>> +/* Mailbox registers structure */
>> +struct rcar_can_mbox_regs {
>> + u32 id; /* IDE and RTR bits, SID and EID */
>> + u8 stub; /* Not used */
>> + u8 dlc; /* Data Length Code - bits [0..3] */
>> + u8 data[8]; /* Data Bytes */
>> + u8 tsh; /* Time Stamp Higher Byte */
>> + u8 tsl; /* Time Stamp Lower Byte */
>> +} __packed;
>
> Sorry, I missed the earlier discussion, but why the _packed?
> One u32 and 12 bytes makes a nice multiple of 4.
Better safe than sorry, it's the layout of the registers in hardware,
don't let the compiler optimize here.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
Download attachment "signature.asc" of type "application/pgp-signature" (243 bytes)
Powered by blists - more mailing lists