netdev - Re: [PATCH 2/4 ethtool] ethtool: Support for configurable RSS hash key.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 20 Jan 2014 13:43:18 +0000
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Venkata Duvvuru <VenkatKumar.Duvvuru@...lex.Com>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH 2/4 ethtool] ethtool: Support for configurable RSS hash
 key.

On Mon, 2014-01-20 at 13:28 +0000, Venkata Duvvuru wrote:
> Ben, Please ignore my previous reply. My reply options were screwed up in that.
> 
> > -----Original Message-----
> > From: Ben Hutchings [mailto:ben@...adent.org.uk]
> > Sent: Monday, January 20, 2014 12:06 AM
> > To: Venkata Duvvuru
> > Cc: netdev@...r.kernel.org
> > Subject: Re: [PATCH 2/4 ethtool] ethtool: Support for configurable RSS hash
> > key.
> > 
> > On Fri, 2014-01-17 at 13:02 +0000, Venkata Duvvuru wrote:
> > > This ethtool patch will primarily implement the parser for the options
> > provided by the user for set and get hashkey before invoking the ioctl.
> > > This patch also has Ethtool man page changes which describes the Usage of
> > set and get hashkey options.
> > 
> > I'd prefer to have this combined with the -x/-X options (and add new long
> > options to reflect that they cover the key as well).
> 
> if we add hashkey options to the existing -x/-X (--show-rxfh-indir/ --set-rxfh-indir), I think it won't be appropriate going by the command name.
> We could change the command name to something like --show-rssconfig /--rss-config but I'm afraid would that be backward compatible?
[...]

That's why I said 'add new long options'.  The ethtool argument parser
allows arbitrarily many aliases for each sub-command.

Ben.

-- 
Ben Hutchings
One of the nice things about standards is that there are so many of them.

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)