lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 21 Jan 2014 17:44:06 +0800 From: Ding Tianhong <dingtianhong@...wei.com> To: Jay Vosburgh <fubar@...ibm.com>, Veaceslav Falico <vfalico@...hat.com>, "David S. Miller" <davem@...emloft.net>, Netdev <netdev@...r.kernel.org>, Andy Gospodarek <andy@...yhouse.net> Subject: [PATCH net-next 2/5] bonding: don't set fail_over_mac if the mode is not active backup The fail_over_mac could be set by sysfs in every mode now, it will cause bonding not to set all slaves to the same MAC address, but in rr, xor, broadcast, lacp mode ,the slaves should have the same MAC address with the master, so don't set the fail_over_mac by sysfs if the mode is not active-backup. Signed-off-by: Ding Tianhong <dingtianhong@...wei.com> --- drivers/net/bonding/bond_options.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/bonding/bond_options.c b/drivers/net/bonding/bond_options.c index 945a666..0996ab4 100644 --- a/drivers/net/bonding/bond_options.c +++ b/drivers/net/bonding/bond_options.c @@ -550,6 +550,12 @@ int bond_option_primary_reselect_set(struct bonding *bond, int primary_reselect) int bond_option_fail_over_mac_set(struct bonding *bond, int fail_over_mac) { + if (bond->params.mode != BOND_MODE_ACTIVEBACKUP) { + pr_err("%s: fail_over_mac only affects active-backup mode\n", + bond->dev->name); + return -EINVAL; + } + if (bond_parm_tbl_lookup(fail_over_mac, fail_over_mac_tbl) < 0) { pr_err("%s: Ignoring invalid fail_over_mac value %d.\n", bond->dev->name, fail_over_mac); -- 1.8.0 -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists