netdev - Re: [PATCH net v2] tuntap: Fix for a race in accessing numqueues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 21 Jan 2014 18:37:45 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	dominic.curran@...rix.com
Cc:	netdev@...r.kernel.org, jasowang@...hat.com, maxk@....qualcomm.com
Subject: Re: [PATCH net v2] tuntap: Fix for a race in accessing numqueues

From: Dominic Curran <dominic.curran@...rix.com>
Date: Mon, 20 Jan 2014 21:59:18 +0000

> A patch for fixing a race between queue selection and changing queues
> was introduced in commit 92bb73ea2("tuntap: fix a possible race between
> queue selection and changing queues").
> 
> The fix was to prevent the driver from re-reading the tun->numqueues
> more than once within tun_select_queue() using ACCESS_ONCE().
> 
> We have been experiancing 'Divide-by-zero' errors in tun_net_xmit() 
> since we moved from 3.6 to 3.10, and believe that they come from a 
> simular source where the value of tun->numqueues changes to zero 
> between the first and a subsequent read of tun->numqueues.
> 
> The fix is a simular use of ACCESS_ONCE(), as well as a multiply
> instead of a divide in the if statement.
> 
> Signed-off-by: Dominic Curran <dominic.curran@...rix.com>
> Cc: Jason Wang <jasowang@...hat.com>
> Cc: Maxim Krasnyansky <maxk@....qualcomm.com>
> ---
> V2: Use multiply instead of divide. Suggested by Eric Dumazet.
>     Fixed email address for maxk. Rebase against net tree.

Can you please respin this against net-next?  Thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html