netdev - Re: [PATCH] net: Fix some fallout from the etner_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 21 Jan 2014 23:23:31 -0500
From:	Bill Fink <billfink@...dspring.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH] net: Fix some fallout from the etner_addr_copy()
 changes.

On Tue, 21 Jan 2014, David Miller wrote:

> net/appletalk/aarp.c: In function ‘__aarp_send_query’:
> net/appletalk/aarp.c:137:2: error: implicit declaration of function ‘ether_addr_copy’ [-Werror=implicit-function-declaration]
>  ...
> net/atm/lec.c: In function ‘send_to_lecd’:
> net/atm/lec.c:524:3: warning: passing argument 1 of ‘ether_addr_copy’ from incompatible pointer type [enabled by default]
> In file included from net/atm/lec.c:17:0:
> include/linux/etherdevice.h:227:20: note: expected ‘u8 *’ but argument is of type ‘unsigned char (*)[6]’
>  ...
> net/caif/caif_usb.c: In function ‘cfusbl_create’:
> net/caif/caif_usb.c:108:2: error: implicit declaration of function ‘ether_addr_copy’ [-Werror=implicit-function-declaration]
> 
> Signed-off-by: David S. Miller <davem@...emloft.net>
> ---
>  net/appletalk/aarp.c | 1 +
>  net/atm/lec.c        | 2 +-
>  2 files changed, 2 insertions(+), 1 deletion(-)

The commit message indicates problems with appletalk/aarp.c,
atm/lec.c, and caif/caif_usb.c, but the diffstat and patch only
address the first two and not caif/caif_usb.c.  Is that intended
or am I missing something.

					-Bill
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html