netdev - Re: [PATCH net-next] net/mlx4_core: Remove unnecessary validation for port number

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 21 Jan 2014 23:14:48 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	amirv@...lanox.com
Cc:	netdev@...r.kernel.org, ogerlitz@...lanox.com,
	monis@...lanox.co.il, matanb@...lanox.com
Subject: Re: [PATCH net-next] net/mlx4_core: Remove unnecessary validation
 for port number

From: Amir Vadai <amirv@...lanox.com>
Date: Tue, 21 Jan 2014 10:19:37 +0200

> From: Moni Shoua <monis@...lanox.co.il>
> 
> This is a fix to a regression introduced by commit:
> "982290a net/mlx4_core: Check port number for validity
> before accessing data"
> 
> IPoIB could not attach to multicast group and we get this in dmesg:
> [144214.145008] ib0: failed to attach to multicast group, ret = -22
> [144214.145016] ib0: couldn't attach QP to multicast group ff12:401b:ffff:0000:0000:0000:ffff:ffff
> [144214.145019] ib0: multicast join failed for ff12:401b:ffff:0000:0000:0000:ffff:ffff, status -22
> 
> The cause to the problem is because port is extracted from gid[5].
> Which is only valid for Ethernet.
> Removed this validation in mlx4_qp_attach_common(), which is accessed
> from both Ethernet and IB flows.
> Error flow for bad port value in Ethernet is already exists in that
> function.
> 
> Signed-off-by: Moni Shoua <monis@...lanox.co.il>
> Signed-off-by: Matan Barak <matanb@...lanox.com>
> Signed-off-by: Amir Vadai <amirv@...lanox.com>

Applied, thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html