lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 29 Jan 2014 11:01:06 +0400 From: Max Filippov <jcmvbkbc@...il.com> To: Florian Fainelli <f.fainelli@...il.com> Cc: "linux-xtensa@...ux-xtensa.org" <linux-xtensa@...ux-xtensa.org>, netdev <netdev@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>, Chris Zankel <chris@...kel.net>, Marc Gauthier <marc@...ence.com>, "David S. Miller" <davem@...emloft.net>, Ben Hutchings <ben@...adent.org.uk> Subject: Re: [PATCH v2 2/4] net: ethoc: don't advertise gigabit speed on attached PHY On Wed, Jan 29, 2014 at 10:47 AM, Florian Fainelli <f.fainelli@...il.com> wrote: > Hi Max, > > Le 28/01/2014 22:00, Max Filippov a écrit : > >> OpenCores 10/100 Mbps MAC does not support speeds above 100 Mbps, but does >> not disable advertisement when PHY supports them. This results in >> non-functioning network when the MAC is connected to a gigabit PHY >> connected >> to a gigabit switch. >> >> The fix is to disable gigabit speed advertisement on attached PHY >> unconditionally. >> >> Signed-off-by: Max Filippov <jcmvbkbc@...il.com> >> --- >> Changes v1->v2: >> - disable both gigabit advertisement and support. >> >> drivers/net/ethernet/ethoc.c | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/drivers/net/ethernet/ethoc.c b/drivers/net/ethernet/ethoc.c >> index 4de8cfd..5643b2d 100644 >> --- a/drivers/net/ethernet/ethoc.c >> +++ b/drivers/net/ethernet/ethoc.c >> @@ -688,6 +688,14 @@ static int ethoc_mdio_probe(struct net_device *dev) >> } >> >> priv->phy = phy; >> + phy_update_advert(phy, >> + ADVERTISED_1000baseT_Full | >> + ADVERTISED_1000baseT_Half, 0); >> + phy_start_aneg(phy); > > > This does not look necessary, you should not have to call phy_start_aneg() > because the PHY state machine is not yet started, at best this calls does > nothing. This call actually makes the whole thing work, because otherwise once gigabit support is cleared from the supported mask genphy_config_advert does not update gigabit advertisement register, leaving it enabled. >> + phy_update_supported(phy, >> + SUPPORTED_1000baseT_Full | >> + SUPPORTED_1000baseT_Half, 0); >> + >> return 0; >> } >> >> > -- Thanks. -- Max -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists