netdev - inet_diag_dump_icsk() change seems bogus...

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 02 Feb 2014 00:45:38 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	netdev@...r.kernel.org
CC:	ncardwell@...gle.com
Subject: inet_diag_dump_icsk() change seems bogus...

Upon further review, commit 70315d22d3c7383f9a508d0aab21e2eb35b2303a
("inet_diag: fix inet_diag_dump_icsk() to use correct state for
timewait sockets") doesn't seem valid to me.

Take a close look at get_tcp4_sock() and get_timewait4_sock() which
you reference in your commit message.

The former always gets it's socket from head->chain and the latter
always gets it's socket from head->twchain.

Yet in this inet_diag_dump_icsk() change, you're changing the
head->chain iterator to check for timewait sockets.  That doesn't
seem possible.

Only head->twchain holds timewait sockets, and this code was handling
it correctly already.

What gives?
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html