netdev - Re: [patch] tg3: cleanup an error path in tg3_phy_reset_5703_4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 06 Feb 2014 20:06:31 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	dan.carpenter@...cle.com
Cc:	nsujir@...adcom.com, mchan@...adcom.com, netdev@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [patch] tg3: cleanup an error path in tg3_phy_reset_5703_4_5()

From: Dan Carpenter <dan.carpenter@...cle.com>
Date: Wed, 5 Feb 2014 16:29:21 +0300

> In the original code, if tg3_readphy() fails then it does an unnecessary
> check to verify "err" is still zero and then returns -EBUSY.
> 
> My static checker complains about the unnecessary "if (!err)" check and
> anyway it is better to propagate the -EBUSY error code from
> tg3_readphy() instead of hard coding it here.  And really the original
> code is confusing to look at.
> 
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html