lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 10 Feb 2014 05:08:41 -0800 From: Eric Dumazet <eric.dumazet@...il.com> To: Herbert Xu <herbert@...dor.apana.org.au> Cc: Florian Westphal <fw@...len.de>, netdev@...r.kernel.org Subject: Re: [PATCH 2/2] net: ip, ipv6: handle gso skbs in forwarding path On Mon, 2014-02-10 at 20:50 +0800, Herbert Xu wrote: > On Mon, Feb 10, 2014 at 01:43:46PM +0100, Florian Westphal wrote: > > > > Eric suggested to shrink gso_size instead to avoid segmentation+fragments. > > I think its nice idea, but skb_gso_segment makes certain assumptions about > > nr_frags and gso_size (it can't handle frag size > desired mss). > > This breaks the most important assumption behind GRO which is > to preserve end-to-end connectivity. Resegmenting packets as > suggested on a router/bridge is just wrong. Yeah, this is the old mantra. Sending TCP packets without DF means the sender do not care by definition. If you disable GRO for such packets, it slows down receivers and increase packet drops. I've added the segmentation for these packets for a reason, that you are free to not understand, but there is absolutely no need reason to not aggregate TCP packets without DF. This is what you suggested to ignore the problem on skb_segment() being so limited. Instead of a router being forced to segment all incoming fragments into X+Y X+Y X+Y X+Y Its reasonable to send X+X+X+X+X And we should be reasonable, not trying to enforce a particular view of what _should_ the traffic looks like on the Internet. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists