netdev - RE: [net-next 05/14 v2] i40evf: fix up strings in init task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 20 Feb 2014 16:20:32 +0000
From:	"Williams, Mitch A" <mitch.a.williams@...el.com>
To:	"Brown, Aaron F" <aaron.f.brown@...el.com>,
	Joe Perches <joe@...ches.com>
CC:	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"gospo@...hat.com" <gospo@...hat.com>,
	"sassmann@...hat.com" <sassmann@...hat.com>,
	"Brandeburg, Jesse" <jesse.brandeburg@...el.com>
Subject: RE: [net-next 05/14 v2] i40evf: fix up strings in init task



> -----Original Message-----
> From: Brown, Aaron F
> Sent: Wednesday, February 19, 2014 9:16 PM
> To: Joe Perches
> Cc: davem@...emloft.net; Williams, Mitch A; netdev@...r.kernel.org;
> gospo@...hat.com; sassmann@...hat.com; Brandeburg, Jesse
> Subject: Re: [net-next 05/14 v2] i40evf: fix up strings in init task
> 
> On Wed, 2014-02-19 at 20:58 -0800, Joe Perches wrote:
> > On Wed, 2014-02-19 at 20:51 -0800, Aaron Brown wrote:
> > > On Wed, 2014-02-19 at 20:09 -0800, Joe Perches wrote:
> > > > On Wed, 2014-02-19 at 19:49 -0800, Aaron Brown wrote:
> > > > > Make sure errors are reported at the correct log level, quit
> printing
> > > > > the function name every time, and make the messages more consistent
> in
> > > > > format.
> > > > []
> > > > > diff --git a/drivers/net/ethernet/intel/i40evf/i40evf_main.c
> b/drivers/net/ethernet/intel/i40evf/i40evf_main.c
> > []
> > > > +		dev_info(&pdev->dev, "Invalid MAC address %pMAC, using
> random\n",
> > > > > +			 adapter->hw.mac.addr);
> > > > The "AC" after %pM is superfluous.
> > > Thanks Joe, guess I'll be making another spin...
> >
> > Or send another patch after this one because there
> > are 2 %pMAC uses in i40evf_main.c
> 
> That works.  I'll bug Mitch to look for them when he does a hunt for other
> OOM messages that he said he'd do and send them up later.  So I guess this
> patch can stand for now.
> 

Added it to my to-do list. Thanks again, Joe.

-Mitch