netdev - Re: [PATCH 1/1] net: tcp: RTO restart

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 21 Feb 2014 11:49:06 +0100
From:	Per Hurtig <per.hurtig@....se>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	Andreas Petlund <apetlund@...ula.no>,
	netdev <netdev@...r.kernel.org>,
	David Miller <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Anna Brunström <anna.brunstrom@....se>,
	Michael Welzl <michawe@....uio.no>,
	Ilpo Järvinen <ilpo.jarvinen@...sinki.fi>
Subject: Re: [PATCH 1/1] net: tcp: RTO restart


On 19 Feb 2014, at 19:01, Eric Dumazet <eric.dumazet@...il.com> wrote:

> On Wed, 2014-02-19 at 18:17 +0100, Andreas Petlund wrote:
>> I’ve applied and tested the patch on VMs with both 32 bit and 64 bit kernel.
>> 
>> Acked-by: Andreas Petlund <apetlund@...ula.no>
>> Tested-by: Andreas Petlund <apetlund@...ula.no>
> 
> Sure the patch applies, but what experimental results did you get ?
> 
> My concern is that TCP_SKB_CB(skb)->when doesn't account for sojourn
> time in host queues (qdisc and device). 
> 

Correct me if I’m wrong, but I was under the impression that the sojourn was
accounted for in the RTT calculations, and therefore rather inappropriate to
be accounted for again? If this assumption is wrong, how would you propose that
we account for the sojourn time?

> Note : Missing documentation for this new sysctl.
> 

Yes, this we completely missed. Will fix.

> This patch certainly cannot be applied as is.
> 
> Thanks !
> 
> 

Thank you,
Per Hurtig


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html