netdev - RE: [PATCH v2 net-next 1/2] ethtool - Support for configurable RSS hash key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 25 Feb 2014 13:06:19 +0000
From:	Venkata Duvvuru <VenkatKumar.Duvvuru@...lex.Com>
To:	Ben Hutchings <ben@...adent.org.uk>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH v2 net-next 1/2] ethtool - Support for configurable RSS
 hash key

> settings */
> >  #define ETHTOOL_SFEATURES	0x0000003b /* Change device offload
> settings */
> [...]
> 
> You can't just redefine commands like this.  Think what will happen if someone
> uses an old version of ethtool with a new kernel.
> 
> You have to keep supporting the old ethtool command numbers and structure.
> And you have to make the ethtool core keep working with all the other drivers
> that don't support setting the key yet (or update them so they do).
> 
> Ben.

Please let me know if I interpreted your reply correctly.
1. Old command numbers, structure and routines will remain unmodified in the kernel space. This will ensure that the new kernel works with the old ethtool indirection table commands.
2. New commands & routines will have the combined functionality of hash key and indirection table.