netdev - Re: [PATCH net-next v4 2/8] 6lowpan: add uncompress header size function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 26 Feb 2014 13:56:26 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	David.Laight@...LAB.COM
Cc:	alex.aring@...il.com, alex.bluesman.smirnov@...il.com,
	dbaryshkov@...il.com, linux-zigbee-devel@...ts.sourceforge.net,
	netdev@...r.kernel.org, martin.townsend@...lon.com
Subject: Re: [PATCH net-next v4 2/8] 6lowpan: add uncompress header size
 function

From: David Laight <David.Laight@...LAB.COM>
Date: Wed, 26 Feb 2014 16:10:05 +0000

> From: Alexander Aring
>> Signed-off-by: Alexander Aring <alex.aring@...il.com>
>> ---
>>  net/ieee802154/6lowpan.h | 116 +++++++++++++++++++++++++++++++++++++++++++++++
>>  1 file changed, 116 insertions(+)
>> 
>> diff --git a/net/ieee802154/6lowpan.h b/net/ieee802154/6lowpan.h
>> index 2b835db..b6ae0bc 100644
>> --- a/net/ieee802154/6lowpan.h
>> +++ b/net/ieee802154/6lowpan.h
>> @@ -306,6 +306,122 @@ static inline void lowpan_push_hc_data(u8 **hc_ptr, const void *data,
>>  	*hc_ptr += len;
>>  }
>> 
>> +static inline u8 lowpan_addr_mode_size(const u8 addr_mode)
>> +{
>> +	switch (addr_mode) {
>> +	case LOWPAN_IPHC_ADDR_00:
>> +		return 16;
>> +	case LOWPAN_IPHC_ADDR_01:
>> +		return 8;
>> +	case LOWPAN_IPHC_ADDR_02:
>> +		return 2;
>> +	default:
>> +		return 0;
>> +	}
>> +}
> 
> The compiler will generate much better code if you index an array instead
> of using a switch statement.

And please mark the array const :-)
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html