netdev - Re: [PATCH net] sch_tbf: Fix potential memory leak in tbf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 27 Feb 2014 07:43:04 +0900
From:	Hiroaki SHIMODA <shimoda.hiroaki@...il.com>
To:	eric.dumazet@...il.com
Cc:	davem@...emloft.net, netdev@...r.kernel.org,
	yangyingliang@...wei.com
Subject: Re: [PATCH net] sch_tbf: Fix potential memory leak in tbf_change().

On Wed, 26 Feb 2014 07:29:44 -0800
Eric Dumazet <eric.dumazet@...il.com> wrote:

> On Wed, 2014-02-26 at 21:43 +0900, Hiroaki SHIMODA wrote:
> > The allocated child qdisc is not freed in error conditions.
> > Defer the allocation after user configuration turns out to be
> > valid and acceptable.
> > 
> > Fixes: cc106e4 ("net: sched: tbf: fix the calculation of max_size")
> 
> Please prefer/use 12 digits : cc106e441a63b
> 
> You can put in your .git/config file :
> 
> [core]
> 	...
> 	abbrev = 12
> 	...

Thank you for your kind suggestion.
I will use 12 digits next time.

> > Signed-off-by: Hiroaki SHIMODA <shimoda.hiroaki@...il.com>
> > Cc: Yang Yingliang <yangyingliang@...wei.com>
> > ---
> 
> Acked-by: Eric Dumazet <edumazet@...gle.com>
> 
> Thanks
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html