netdev - Re: [PATCH] bonding: disallow enslaving a bond to itself

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 27 Feb 2014 09:30:56 +0800
From:	Ding Tianhong <dingtianhong@...wei.com>
To:	Jiri Bohac <jbohac@...e.cz>, Jay Vosburgh <fubar@...ibm.com>
CC:	<netdev@...r.kernel.org>
Subject: Re: [PATCH] bonding: disallow enslaving a bond to itself

On 2014/2/27 1:20, Jiri Bohac wrote:
> Enslaving a bond to itself leads to an endless loop and hangs the kernel.
> 

Yes, I met the same problem.

Tested-by: Ding Tianhong <dingtianhong@...wei.com>

> Signed-off-by: Jiri Bohac <jbohac@...e.cz>
> 
> diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
> index 1c6104d..8f028ac 100644
> --- a/drivers/net/bonding/bond_main.c
> +++ b/drivers/net/bonding/bond_main.c
> @@ -1193,6 +1193,11 @@ int bond_enslave(struct net_device *bond_dev, struct net_device *slave_dev)
>  		return -EBUSY;
>  	}
>  
> +	if (bond_dev == slave_dev) {
> +		pr_err("%s: cannot enslave bond to itself.\n", bond_dev->name);
> +		return -EPERM;
> +	}
> +
>  	/* vlan challenged mutual exclusion */
>  	/* no need to lock since we're protected by rtnl_lock */
>  	if (slave_dev->features & NETIF_F_VLAN_CHALLENGED) {
> 


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html