lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 07 Mar 2014 07:44:20 +0100 From: Christian Riesch <christian.riesch@...cron.at> To: David Miller <davem@...emloft.net> cc: davinci-linux-open-source@...ux.davincidsp.com, f.fainelli@...il.com, netdev@...r.kernel.org, stable@...r.kernel.org, jon@...gle.org Subject: Re: [PATCH] net: davinci_emac: Replace devm_request_irq with request_irq [Sent again, sorry for the HTML mail before.] --On March 06, 2014 16:57 -0500 David Miller <davem@...emloft.net> wrote: > From: Christian Riesch <christian.riesch@...cron.at> > Date: Wed, 5 Mar 2014 11:25:28 +0100 > >> @@ -1641,7 +1640,15 @@ static int emac_dev_open(struct net_device *ndev) >> >> rollback: >> >> - dev_err(emac_dev, "DaVinci EMAC: devm_request_irq() failed"); >> + dev_err(emac_dev, "DaVinci EMAC: request_irq() failed"); >> + >> + for (q = k; k >= 0; k--) { >> + for (m = i; m >= res->start; m--) >> + free_irq(m, ndev); >> + res = platform_get_resource(priv->pdev, IORESOURCE_IRQ, k-1); >> + m = res->end; >> + } > > This final assignment in the loop of 'm' is unused? > > The inner for() loop always started with "m = i;" This should probably read i = res->end; I just took the old code without thinking about it. Thanks for catching it. Christian -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists