netdev - Re: [PATCH net-next] vlan: Fix lockdep warning when vlan dev handle notification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 10 Mar 2014 10:08:35 +0800
From:	Ding Tianhong <dingtianhong@...wei.com>
To:	David Miller <davem@...emloft.net>
CC:	<ben@...adent.org.uk>, <john.r.fastabend@...el.com>,
	<kaber@...sh.net>, <netdev@...r.kernel.org>, <f.fainelli@...il.com>
Subject: Re: [PATCH net-next] vlan: Fix lockdep warning when vlan dev handle
 notification

On 2014/3/7 14:49, David Miller wrote:
> From: Ding Tianhong <dingtianhong@...wei.com>
> Date: Fri, 7 Mar 2014 09:55:25 +0800
> 
>> But I think if I vconfig add eth2.20.30 50, the warning would happen
>> again, but till now I could not find any scene that use 3 vlan id on
>> a virtual device, so I think it is not a problem.
> 
> My example was to show that you aren't really fixing the bug, but
> rather are papering over it.
> 
> In that sense, it is a problem.
> 
> I also happen to disagree with your assertion that a 3 layered
> VLAN is invalid, it is valid.  And if we allow the configuration
> it shouldn't throw locking assertions.
> 
> 
OK, thanks for your advise. I would think and solve this problem once-again.

Regards
Ding



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html