netdev - Re: [PATCH V1 net-next 2/7] mlx4_core: For RoCE, allow slaves to set the GID entry at that slave's index

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 11 Mar 2014 22:12:33 +0200
From:	Or Gerlitz <or.gerlitz@...il.com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:	Or Gerlitz <ogerlitz@...lanox.com>,
	David Miller <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	Roland Dreier <roland@...nel.org>,
	Jack Morgenstein <jackm@....mellanox.co.il>,
	Amir Vadai <amirv@...lanox.com>
Subject: Re: [PATCH V1 net-next 2/7] mlx4_core: For RoCE, allow slaves to set
 the GID entry at that slave's index

On Tue, Mar 11, 2014 at 9:12 PM, Sergei Shtylyov
<sergei.shtylyov@...entembedded.com> wrote:
> Hello.
>
>
> On 03/11/2014 04:02 PM, Or Gerlitz wrote:
>
>> From: Jack Morgenstein <jackm@....mellanox.co.il>
>
>
>> For IB transport, the host determines the slave GIDs. For ETH (RoCE),
>> however, the slave's GID is determined by the IP address that the slave
>> itself assigns to the ETH device used by RoCE.
>
>
>> In this case, the slave must be able to write its GIDs to the HCA gid
>> table
>> (at the GID indices that slave "owns").
>
>
>> This commit adds processing for the SET_PORT_GID_TABLE opcode modifier
>> for the SET_PORT command wrapper (so that slaves may modify their GIDS
>> for RoCE).
>
>
>> Signed-off-by: Jack Morgenstein <jackm@....mellanox.co.il>
>> Signed-off-by: Or Gerlitz <ogerlitz@...lanox.com>
>> ---
>>   drivers/net/ethernet/mellanox/mlx4/port.c |   27
>> ++++++++++++++++++++++++++-
>>   1 files changed, 26 insertions(+), 1 deletions(-)
>
>
>> diff --git a/drivers/net/ethernet/mellanox/mlx4/port.c
>> b/drivers/net/ethernet/mellanox/mlx4/port.c
>> index 9c063d6..095f74d 100644
>> --- a/drivers/net/ethernet/mellanox/mlx4/port.c
>> +++ b/drivers/net/ethernet/mellanox/mlx4/port.c
>
> [...]
>
>> @@ -581,6 +584,28 @@ static int mlx4_common_set_port(struct mlx4_dev *dev,
>> int slave, u32 in_mod,
>>
>>                         gen_context->mtu =
>> cpu_to_be16(master->max_mtu[port]);
>>                         break;
>> +               case MLX4_SET_PORT_GID_TABLE:
>> +                       gid_entry = (struct mlx4_roce_gid_entry
>> *)(inbox->buf);
>> +                       /* check that do not have duplicates */
>> +                       if (memcmp(gid_entry->raw, zgid_entry.raw, 16)) {
>> +                               for (i = 0; i < MLX4_ROCE_MAX_GIDS; i++) {
>> +                                       if (slave != i &&
>> +                                           !memcmp(gid_entry->raw,
>> priv->roce_gids[port - 1][i].raw, 16)) {
>
>
>    This line is over 80 columns, as checkpatch.pl would have told.

Indeed, I don't think the 80 columns warning of checkpatch is
considered a gating factor for accepting patches, so I would prefer
not to re-spin the series just to fix this sort of warnings.


>
>
>> +                                               mlx4_warn(dev, "requested
>> gid entry for slave:%d "
>> +                                                         "is a duplicate
>> of slave %d\n",
>
>
>     checkpatch.pl would have warned not to break up the string literal here
> -- it's an exception from the 80-column rule.

I see, yep, I assume we can fix that if needed.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html