netdev - Re: [Patch 1/2] IB/mlx5: Implementation of PCI error handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 12 Mar 2014 17:00:37 -0500
From:	Carol Soto <clsoto@...ux.vnet.ibm.com>
To:	Ben Hutchings <ben@...adent.org.uk>
CC:	eli@...lanox.com, roland@...nel.org, sean.hefty@...el.com,
	hal.rosenstock@...il.com, linux-rdma@...r.kernel.org,
	netdev@...r.kernel.org, brking@...ux.vnet.ibm.com
Subject: Re: [Patch 1/2] IB/mlx5: Implementation of PCI error handler


On 3/12/2014 1:34 PM, Ben Hutchings wrote:
> On Tue, 2014-03-11 at 22:42 -0500, clsoto@...ux.vnet.ibm.com wrote:
> [...]
>> Index: b/include/linux/mlx5/driver.h
>> ===================================================================
>> --- a/include/linux/mlx5/driver.h
>> +++ b/include/linux/mlx5/driver.h
>> @@ -51,10 +51,10 @@ enum {
>>   };
>>   
>>   enum {
>> -       /* one minute for the sake of bringup. Generally, commands must always
>> +       /* 10 msecs for the sake of bringup. Generally, commands must always
>>           * complete and we may need to increase this timeout value
>>           */
>> -       MLX5_CMD_TIMEOUT_MSEC   = 7200 * 1000,
>> +       MLX5_CMD_TIMEOUT_MSEC   = 10 * 1000,
> You seem to be changing the timeout from 2 hours (not one minute) to 10
> seconds (not milliseconds).
>
> Ben.
Yes you are right the comment should say 10 seconds instead of 10 msecs.

Carol
>
>>          MLX5_CMD_WQ_MAX_NAME    = 32,
>>   };
>>   
>>


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html