netdev - RE: [PATCH V3 2/8] net: sxgbe: add basic framework for Samsung 10Gb ethernet driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 17 Mar 2014 14:58:05 -0700
From:	Byungho An <bh74.an@...sung.com>
To:	'David Miller' <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
	siva.kallam@...sung.com, vipul.pandya@...sung.com,
	ks.giri@...sung.com, ilho215.lee@...sung.com
Subject: RE: [PATCH V3 2/8] net: sxgbe: add basic framework for Samsung 10Gb
 ethernet driver


David Miller <davem@...emloft.net> :
> From: Byungho An <bh74.an@...sung.com>
> Date: Mon, 17 Mar 2014 13:43:37 -0700
> 
> > +static void sxgbe_tx_timer(unsigned long data) {
> > +	struct sxgbe_tx_queue *p = (struct sxgbe_tx_queue *)data;
> > +	sxgbe_tx_queue_clean(p);
> > +}
> 
> A empty line after local variable declarations please.
> 
> > +	SXGBE_FOR_EACH_QUEUE(SXGBE_TX_QUEUES, queue_num) {
> > +		struct sxgbe_tx_queue *p = priv->txq[queue_num];
> > +		p->tx_coal_frames =  SXGBE_TX_FRAMES;
> 
> Likewise.
> 
> > +	SXGBE_FOR_EACH_QUEUE(SXGBE_TX_QUEUES, queue_num) {
> > +		struct sxgbe_tx_queue *p = priv->txq[queue_num];
> > +		del_timer_sync(&p->txtimer);
> > +	}
> 
> Likewise.
> 
> Please audit your entire submission for this problem.
OK, will do that.

> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in the
body of
> a message to majordomo@...r.kernel.org More majordomo info at
> http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html