netdev - Re: [PATCH] net: cpsw: do not register cpts twice

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 17 Mar 2014 22:18:24 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	b.spranger@...utronix.de
Cc:	netdev@...r.kernel.org, tglx@...utronix.de, mugunthanvnm@...com,
	balbi@...com
Subject: Re: [PATCH] net: cpsw: do not register cpts twice

From: Benedikt Spranger <b.spranger@...utronix.de>
Date: Sun, 16 Mar 2014 16:36:29 +0100

> commit f280e89a (drivers: net: cpsw: fix for cpsw crash when build as modules)
> moved cpts_register()/cpts_unregister() to  ndo_open()/ndo_stop(), but failed
> to remove cpts_register in cpsw_probe() which leads to a double registration
> and the following debug object splat.
> 
> [   18.991902] ODEBUG: init active (active state 0) object type: timer_list hint: delayed_work_timer_fn+0x0/0x2c
> [   19.082249] [<c0059e80>] (init_timer_key) from [<c04965d4>] (cpts_register+0x1f0/0x2c4)
> [   19.090642] [<c04965d4>] (cpts_register) from [<c04931dc>] (cpsw_ndo_open+0x780/0x81c)
> [   19.098948] [<c04931dc>] (cpsw_ndo_open) from [<c0599c2c>] (__dev_open+0xb4/0x118)
> 
> Signed-off-by: Benedikt Spranger <b.spranger@...utronix.de>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html